New checkpoint request protocol - #97
Merged
Merged
Conversation
simolus3
reviewed
Aug 31, 2026
simolus3
left a comment
simolus3
left a comment
Contributor
There was a problem hiding this comment.
I wanted to leave a few early comments in case it helps. As far as the public API is concerned this looks good to me.
LucDeCaf
added
the
Product Visibility
…dard2.0 runtime features, use manual locking in CheckpointStateSignals
LucDeCaf
marked this pull request as ready for review
September 3, 2026 09:40
simolus3
previously approved these changes
Sep 7, 2026
simolus3
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the new Checkpoint Requests protocol for .NET, using the other SDKs as reference (mostly JS and Kotlin).
This PR also includes a internal refactor to the StreamingSyncImplementation class, which shifts it closer to the Kotlin SDK's implementation rather than JavaScript's.
Note that this uses strings for the checkpoint request ID despite C# having a fast, native 64-bit integer type. This is mostly for consistency with other internal APIs and to avoid any accidental public API changes, but I'd like to use longs for IDs in v1.
AI Usage
I used Claude Code to assist with the StreamingSyncImplementation refactor and with porting tests/test utils from Kotlin/JS to C#. I reviewed the changes manually.